[PATCH 09/33] ARM: ux500: Supply the I2C clocks lookup to the DBX500 DT

Linus Walleij linus.walleij at linaro.org
Wed Aug 21 18:44:55 EDT 2013


On Wed, Aug 21, 2013 at 10:28 AM, Lee Jones <lee.jones at linaro.org> wrote:
> On Tue, 20 Aug 2013, Linus Walleij wrote:
>> On Thu, Jun 6, 2013 at 2:16 PM, Lee Jones <lee.jones at linaro.org> wrote:
>>
>> > +++ b/arch/arm/boot/dts/dbx5x0.dtsi
>> > @@ -572,6 +572,8 @@
>> >                         v-i2c-supply = <&db8500_vape_reg>;
>> >
>> >                         clock-frequency = <400000>;
>> > +                       clocks = <&prcc_kclk 3 3>, <&prcc_pclk 3 3>;
>> > +                       clock-names = "nmk-i2c.0", "apb_pclk";
>>
>> To avoid confusing the clock name "nmk-i2c.0" with the device
>> name in Linux of that device instance, can we use a name such
>> that it is clear that this is not a dev_name match?
>>
>> "i2c0" works just fine as name I think?
>
> If you do that, then I think you need to change all of these too:
>
> git grep -e "\.0" -e "\.1" -e "\.2" -e "\.3" -- drivers/clk/ux500/

No, as I said in some other patch, all these clk_register_clkdev()s
are unused in device tree boots and should not even be executed
on the DT boot path.

(But maybe you've proven me wrong there in this other
thread ...)

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list