[PATCH 1/2] DMA: fix AMBA PL08x driver issue with 64bit DMA address type

Linus Walleij linus.walleij at linaro.org
Wed Aug 21 17:01:08 EDT 2013


On Wed, Aug 14, 2013 at 2:52 PM, Andre Przywara
<andre.przywara at linaro.org> wrote:

> In Rob's recent pull request the patch
>         ARM: highbank: select ARCH_DMA_ADDR_T_64BIT for LPAE
> promotes dma_addr_t to 64bit, which breaks compilation of the
> AMBA PL08x DMA driver.
> GCC has no function for the 64bit/8bit modulo operation.
> Looking more closely the divisor can only be 1, 2 or 4, so the full
> featured '%' modulo operation is overkill and can be replaced by
> simple bit masking.
>
> Signed-off-by: Andre Przywara <andre.przywara at linaro.org>

Can you give some context? Which platform have you tested
this on after the change, or is this only compile-tested?

Of the current defconfigs selecting this driver, none is 64bit,
so makes me a bit curious if there is really some PL08x
on the Highbank or similar?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list