[PATCH 00/12] DRA7xx PRCM, hwmod and DT data

Paul Walmsley paul at pwsan.com
Wed Aug 21 04:55:58 EDT 2013


On Tue, 9 Jul 2013, Rajendra Nayak wrote:

> This series adds the data files for DRA7xx devices for
> PRCM, hwmod and DT. This is dependent on the core support [1]
> patches for DRA7xx and leaves out the clock data since its
> on its way to DT [2]
> 
> The regbit headers for prm and cm are cleaned up post the
> autogeneration as 95% was seen to be currently unused
> (prm-regbits-7xx.h was 100% unused and hence removed)
> 
> These patches along with the core support patches are available at:
> git://github.com/rrnayak/linux.git for-3.12/dra-core-data

Have glanced through these patches.  The form looks okay to me.  But again 
it's impossible to me to spot-check or verify almost anything in the data 
here, until some documentation is available.  Nor can I verify that the 
series works here, since I don't have a DRA7xx board.  It would be best 
for TI and for upstream Linux if us maintainers outside TI could at least 
test these patches, otherwise we are flying blind.

One minor comment is that I think the credit information in the comments 
of the data files needs to be qualified.  Instead of simply:

+ * Paul Walmsley (paul at pwsan.com)
+ * Rajendra Nayak (rnayak at ti.com)
+ * Benoit Cousson (b-cousson at ti.com)

it would be better if it read something like:

* Generated by code originally written by:
* Paul Walmsley (paul at pwsan.com)
* Rajendra Nayak (rnayak at ti.com)
* Benoit Cousson (b-cousson at ti.com)

or something similar.  Same for the other generated data files.

Are you fine with this change, or do you have some similar wording that 
you think is better?    No need to repost, I'll update the patches here.


- Paul



More information about the linux-arm-kernel mailing list