[PATCH v5 1/8] usb: phy: omap-control: Get rid of platform data
thomas.langer at lantiq.com
thomas.langer at lantiq.com
Tue Aug 20 11:04:44 EDT 2013
Hello Roger,
this will not work!
Roger Quadros wrote on 2013-08-20:
> - struct omap_control_usb_platform_data *pdata =
> - dev_get_platdata(&pdev->dev);
> +
> + if (np) {
> + of_property_read_u32(np, "ti,type", &control_usb->type);
here you are dereferencing control_usb
> + } else {
> + /* We only support DT boot */
> + return -EINVAL;
> + }
>
> control_usb = devm_kzalloc(&pdev->dev, sizeof(*control_usb),
> GFP_KERNEL);
and here it is allocated!
Best Regards,
Thomas
More information about the linux-arm-kernel
mailing list