[PATCH v4 1/3] ARM: bcm281xx: Add GPIO driver

Stephen Warren swarren at wwwdotorg.org
Mon Aug 19 18:50:17 EDT 2013

On 08/19/2013 12:59 PM, Markus Mayer wrote:
> This patch adds the GPIO driver for the bcm281xx family of chips.

> diff --git a/Documentation/devicetree/bindings/gpio/gpio-bcm-kona.txt b/Documentation/devicetree/bindings/gpio/gpio-bcm-kona.txt

The simple way to avoid the discussion re: the name of the file might
have been to name it exactly matching the compatible value it documents,
i.e. brcm,kona-gpio.txt. That's what I personally prefer, but it's not
mandatory in any way at all.

> +Broadcom Kona Family GPIO
> +-------------------------
> +
> +This GPIO driver is used in the following Broadcom SoCs:
> +  BCM11130, BCM11140, BCM11351, BCM28145, BCM28155
> +
> +The GPIO controller only supports edge, not level, triggering of interrupts.
> +
> +- compatible: "brcm,kona-gpio"

Per recent discussions, all the supported compatible values should be
spelled out here, which I assume are:


Documenting all of them allows drivers to implement quirks/workarounds
based on individual SoCs if ever needed.

Aside from that, the binding seems reasonable, so the binding,
Acked-by: Stephen Warren <swarren at nvidia.com>

More information about the linux-arm-kernel mailing list