[PATCH RFC 3/3] spmi: document the PMIC arbiter SPMI bindings

Kumar Gala galak at codeaurora.org
Fri Aug 16 15:48:59 EDT 2013


On Aug 16, 2013, at 2:25 PM, Josh Cartwright wrote:

> Hey Kumar-
> 
> Thanks for the review.
> 
> On Fri, Aug 16, 2013 at 01:53:27PM -0500, Kumar Gala wrote:
>> On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote:
>> 
>>> Signed-off-by: Josh Cartwright <joshc at codeaurora.org>
>>> ---
>>> .../devicetree/bindings/spmi/spmi-pmic-arb.txt     | 26 ++++++++++++++++++++++
>>> 1 file changed, 26 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/spmi/spmi-pmic-arb.txt
>> 
>> As this is a qcom specific binding, I think the file name should be msm-spmi-pmic-arb.txt or something like that.
> 
> Agreed.  It might be nice to use a vendor prefix in the name too.  How's qcom,msm-pmic-arb.txt sound?

Sounds good, as I see we have other examples of having a comma in file names for bindings.

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation




More information about the linux-arm-kernel mailing list