[PATCH 4/5] pinctrl: imx: do not fail when parsing a function fails

Linus Walleij linus.walleij at linaro.org
Wed Aug 14 16:37:32 EDT 2013


On Fri, Aug 9, 2013 at 2:20 PM, Sascha Hauer <s.hauer at pengutronix.de> wrote:

> When parsing a function fails this is no reason to make the whole
> driver fail. Just continue with the next function.
>
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
(...)
> -       for_each_child_of_node(np, child) {
> -               ret = imx_pinctrl_parse_functions(child, info, i++);
> -               if (ret) {
> -                       dev_err(&pdev->dev, "failed to parse function\n");
> -                       return ret;
> -               }
> -       }
> +       for_each_child_of_node(np, child)
> +               imx_pinctrl_parse_functions(child, info, i++);

But is there a reason to stop printing an error message
about it?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list