[PATCH v6 04/11] ARM: mmp: avoid to include head file in mach-mmp

[Daniel Drake]

On Fri, Jul 26, 2013 at 4:05 AM, Haojian Zhuang
<haojian.zhuang at gmail.com> wrote:
> pxa910_set_wake() & mmp2_set_wake() are both declared in head files
> of arch/arm/mach-mmp/include/mach directory. If we include these
> head files in irq-mmp driver, it blocks the multiplatform build.
> So adjust the code.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang at gmail.com>

This fails to build with CONFIG_PM=n, since mmp2_set_wake() is not
defined anywhere.
This is not a regression introduced by this patch, but now seems like
a good time to fix that minor problem.

Could this line
       icu_irq_chip.irq_set_wake = mmp2_set_wake;
be moved to mmp2_pm_init() in pm-mmp2.c (or is that too late)?
If so you could even make the mmp2_set_wake function static.

Thanks
Daniel