[PATCH] ARM: signal: sigreturn_codes should be endian neutral to work in BE8
Victor Kamensky
victor.kamensky at linaro.org
Tue Aug 13 10:59:55 EDT 2013
On 13 August 2013 05:33, Dave Martin <Dave.Martin at arm.com> wrote:
> On Tue, Aug 13, 2013 at 01:12:45PM +0100, Russell King - ARM Linux wrote:
>> On Tue, Aug 13, 2013 at 12:12:11AM -0700, Victor Kamensky wrote:
>> > In case of BE8 kernel data is in BE order whereas code stays in LE
>> > order. sigreturn_codes array initializer need to use macros from
>> > <asm/opcodes.h> to setup instructions code in endian neutral way.
>> >
>> > Problem was discovered during ltp testing of BE system: all rt_sig*
>> > tests failed. Tested against the same tests in both BE and LE modes.
>>
>> It might make more sense to move these into a .S file actually.
>
> That would make sense. Since the kernel assumes v4, I think we can
> assume sufficiently Thumb-capable tools that all these instructions can
> be assembled directly without needing magic numbers.
>
> Then the swabbing should be correct in vmlinux with no extra effort.
Ok, I will try to redo this with .S file.
Thanks,
Victor
> Cheers
> ---Dave
More information about the linux-arm-kernel
mailing list