[PATCH V2] USB: OHCI: make ohci-nxp a separate driver

Greg KH greg at kroah.com
Mon Aug 12 16:22:49 EDT 2013


On Sat, Aug 10, 2013 at 01:14:15PM +0530, Manjunath Goudar wrote:
> Separate the OHCI NXP host controller driver from ohci-hcd
> host code so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM.
> 
> Many place function name and struct name started with usb,
> current scenario replaced usb with ohci for proper naming.
> 
> Signed-off-by: Manjunath Goudar <manjunath.goudar at linaro.org>
> Signed-off-by: Deepak Saxena <dsaxena at linaro.org>
> Acked-by: Alan Stern <stern at rowland.harvard.edu>
> Cc: Arnd Bergmann <arnd at arndb.de>
> Cc: Greg KH <greg at kroah.com>
> Cc: linux-usb at vger.kernel.org
> 
> V2:
>   - Directive check NXP_PLATFORM_DRIVER block has been removed.
> ---
>  drivers/usb/host/Kconfig    |    8 +++
>  drivers/usb/host/Makefile   |    1 +
>  drivers/usb/host/ohci-hcd.c |   18 -------
>  drivers/usb/host/ohci-nxp.c |  124 +++++++++++++++++--------------------------
>  4 files changed, 58 insertions(+), 93 deletions(-)

Also failed to apply:

checking file drivers/usb/host/Kconfig
Hunk #1 FAILED at 398.
1 out of 1 hunk FAILED
checking file drivers/usb/host/Makefile
Hunk #1 FAILED at 50.
1 out of 1 hunk FAILED
checking file drivers/usb/host/ohci-hcd.c
Hunk #1 succeeded at 1212 with fuzz 1 (offset 18 lines).
Hunk #2 succeeded at 1349 with fuzz 1 (offset 53 lines).
Hunk #3 FAILED at 1309.
Hunk #4 FAILED at 1357.
2 out of 4 hunks FAILED
checking file drivers/usb/host/ohci-nxp.c

{sigh}

That's why I required a senior Linaro developer to approve these
patches.  You just wasted a bunch of my time, and it was obvious that no
one else actually tried these patches out, as they can't even be
applied!

Deepak, come on, you know better :(

greg k-h



More information about the linux-arm-kernel mailing list