[PATCHv3 1/9] memory: emif: Move EMIF register defines to include/linux/

Greg Kroah-Hartman gregkh at linuxfoundation.org
Mon Aug 12 15:32:41 EDT 2013


On Thu, Aug 08, 2013 at 09:35:46AM -0400, Santosh Shilimkar wrote:
> (You have not CC'ed Greg, Looping him)
> 
> On Tuesday 06 August 2013 01:49 PM, Dave Gerlach wrote:
> > OMAP4 and AM33XX share the same EMIF controller IP. Although there
> > are significant differences in the IP integration due to which
> > AM33XX can't reuse the EMIF driver DVFS similar to OMAP4,
> > it can definitely benefit by reusing the EMIF related macros
> > defined in drivers/memory/emif.h.
> > 
> > In the current OMAP PM framework the PM code resides under
> > arch/arm/mach-omap2/. To enable reuse of the register defines move
> > the register defines in the emif header file to include/linux so that
> > both the EMIF driver and the AM33XX PM code can benefit.
> > 
> > Signed-off-by: Dave Gerlach <d-gerlach at ti.com>
> > Cc: Santosh Shilimkar <santosh.shilimkar at ti.com>
> > Cc: Benoit Cousson <benoit.cousson at linaro.org>
> > Cc: Aneesh V <aneesh at ti.com>
> > ---
> >  drivers/memory/emif.h   |  543 +--------------------------------------------
> >  include/linux/ti_emif.h |  558 +++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 559 insertions(+), 542 deletions(-)
> >  create mode 100644 include/linux/ti_emif.h
> > 
> For file movement or some part of file movement, while formating
> patch, use "git format-patch -C" so that only delta change will
> appear in the patch.
> 
> The patch as such is fine by me.
> Acked-by: Santosh Shililmar <santosh.shilimkar at ti.com>
> 
> Greg,
> Your ack is needed on this patch so that it can go
> along with the series. Subsequent patch from this series
> use the register defines from this patch.

Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>



More information about the linux-arm-kernel mailing list