[PATCH 15/16] Add EFI stub for ARM
Mark Salter
msalter at redhat.com
Mon Aug 12 10:51:53 EDT 2013
On Fri, 2013-08-09 at 16:26 -0700, Roy Franz wrote:
> +static int relocate_kernel(efi_system_table_t *sys_table,
> + unsigned long *zimage_addr,
> + unsigned long zimage_size,
> + unsigned long min_addr, unsigned long max_addr)
> +{
> + /* Get current address of kernel. */
> + unsigned long cur_zimage_addr = *zimage_addr;
> + unsigned long new_addr = 0;
> +
> + efi_status_t status;
> +
> + if (!zimage_addr || !zimage_size)
> + return EFI_INVALID_PARAMETER;
> +
This parameter check is too late. You already used zimage_addr to
initialize cur_zimage_addr.
--Mark
More information about the linux-arm-kernel
mailing list