[PATCH 1/3] ARM: dts: mxs: set dcp to "disabled" by default

[Kumar Gala]

On Aug 12, 2013, at 7:05 AM, Lothar Waßmann wrote:

> Hi,
> 
> Shawn Guo writes:
>> On Thu, Aug 08, 2013 at 03:30:27PM +0200, Lothar Waßmann wrote:
>>> Reintroduce 'status = "disabled"' for the dcp node that was dropped by
>>> commit 519d8b1a "Added support for Freescale's DCP co-processor".
>> 
>> For IP blocks that do not have pins to be routed on boards, it should be
>> fine to have it enabled in <soc>.dtsi.
>> 
> That means that when a new driver is added, it will start wasting
> resources on all board using that SoC unless the board maintainers
> explicitly disable that driver in DTB.
> 
> I would prefer things to be the other way:
> New drivers (no matter whether for chip-internal or external hardware)
> should require to be explicitly enabled for those platforms on which
> they are being used.

But that enablement should be in the kernel and not the device tree.  The device tree is describing the HW, if the DCP exists and is usable w/o an external IO than by default it should be enabled in the SoC .dts

- k

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation