[PATCH v14 06/12] usb: chipidea: add flag CI_HDRC_DUAL_ROLE_NOT_OTG

Alexander Shishkin alexander.shishkin at linux.intel.com
Fri Aug 9 09:21:32 EDT 2013


Peter Chen <peter.chen at freescale.com> writes:

> On Fri, Aug 09, 2013 at 03:55:56PM +0300, Alexander Shishkin wrote:
>> > +		} else {
>> > +			/*
>> > +			 * If the controller is not OTG capable, but support
>> > +			 * role switch, the defalt role is gadget, and the
>> > +			 * user can switch it through debugfs (proc in future?)
>> 
>> It's not going to be in procfs ever, so that part of the comment can go.
>> 
>
> I can delete now, but the role switch does not a debug function, we
> may not put it at debugfs, do you think so?

Even if we were to put the role switch elsewhere, it wouldn't be
procfs.

If there is indeed a hardware platform that intentionally allows
software to select the role, then yes. Right now, it is a debugging
feature.

Regards,
--
Alex



More information about the linux-arm-kernel mailing list