[PATCH RESEND 1/2] clk: mmp: use global clock lock

Daniel Drake dsd at laptop.org
Thu Aug 8 13:17:16 EDT 2013


Hi,

Sorry for the late response.

On Thu, Jul 25, 2013 at 8:42 PM, Haojian Zhuang
<haojian.zhuang at gmail.com> wrote:
> Currently lock is defined in pxa910, pxa168 & mmp2 clock driver. Only
> one of these driver
> could be active in real system. So I can't see any benefit to use the
> shared clock lock among
> these three drivers.

As far as I can see, my patch does not attempt to share the clock
between those 3 platforms. Instead it only affects the mmp2 case.

The mmp2 case does *already* have a shared clock lock defined in
static bindings (drivers/clk/mmp/clk-mmp2.c):
static DEFINE_SPINLOCK(clk_lock);

This lock is shared between MMP apmu and apbc drivers.

My patch simply moves the location of where the shared clk_lock is
defined so that it can be additionally used by dynamic DT-driven
bindings. If you take a quick glance at the next patch, "clk: mmp: add
support for DT-defined clocks" the reasoning behind this change is
hopefully even clearer.

Thanks
Daniel



More information about the linux-arm-kernel mailing list