[PATCH 2/5] clk: tegra: Add reset only clock node flag and COP
Mark Zhang
markz at nvidia.com
Thu Aug 8 01:50:22 EDT 2013
Okay, I don't know these background infos. If so, there is no reason to
upstream this kind of patches.
On 08/08/2013 12:58 AM, Stephen Warren wrote:
> On 08/07/2013 05:25 AM, Mark Zhang wrote:
>> From: Peter De Schrijver <pdeschrijver at nvidia.com>
>>
>> COP is a reset only clock. So this patch adds NO_CLK support
>> then adds the COP clock.
>
> Do we actually need this clock upstream yet?
>
> IIRC, Prashant was working on implementing the common reset API, so I'd
> prefer not to add any reset-only "clocks" to the clock driver, but
> rather to simply make sure that the new reset driver exposes them.
>
>> diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
>
>> enum tegra114_clk {
>> - rtc = 4, timer = 5, uarta = 6, sdmmc2 = 9, i2s1 = 11, i2c1 = 12,
>> + cop = 1, rtc = 4, timer = 5, uarta = 6, sdmmc2 = 9, i2s1 = 11, i2c1 = 12,
>
> To make this change, you would also need to edit
> include/dt-bindings/clock/tegra114-car.h. BTW, why doesn't the Tegra
> clock driver include that file rather than defining its own enum?
>
More information about the linux-arm-kernel
mailing list