[PATCH v2] pinctrl: shut up a couple of pinctrl warnings

Linus Walleij linus.walleij at linaro.org
Wed Aug 7 14:19:35 EDT 2013


On Sun, Jul 28, 2013 at 2:13 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:

> So, I notice that we get a couple of warnings from the pinctrl code:
>
> drivers/pinctrl/pinconf.c: In function 'pinconf_dbg_config_print':
> drivers/pinctrl/pinconf.c:433:36: warning: 'configs' may be used uninitialized in this function
> drivers/pinctrl/pinconf.c: In function 'pinconf_dbg_config_write':
> drivers/pinctrl/pinconf.c:511:36: warning: 'configs' may be used uninitialized in this function
>
> While the compiler might not be able to work out that "configs" is
> safe, the code doesn't lend itself very well to identifying that
> fact when reading it either.  This can be trivially solved by a slight
> restructuring of the code - which also reduces the LOC.
>
> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> ---
> So last nights build test found a silly in the last patch, so that's fixed
> in this version.

Thanks Russell, patch applied. Sorry for taking so long.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list