[PATCH RFC 10/13] ASoC: kirkwood-t5325: add DAPM links between codec and cpu DAI
broonie at kernel.org
Mon Aug 5 10:40:54 EDT 2013
On Mon, Aug 05, 2013 at 12:33:10PM +0100, Russell King - ARM Linux wrote:
> On Mon, Aug 05, 2013 at 12:27:33PM +0100, Mark Brown wrote:
> > This doesn't look good - this is adding DAPM routes which should
> > correspond to the DAI link that's already been configured.
> No, you're wrong there:
> CPU DAI: Codec DAI
> dma-playback ---> i2sdo ---> Playback
> `--> spdifdo -> not connected
> dma-capture <--- i2sdi <--- Capture
> And the intermediate level is needed to determine which outputs from
> the chip are wired up.
Right, and that's exactly what the dai_links are doing - they're showing
what's hanging off each of the DAIs.
> And don't even say "use dpcm" - if you say that, I want _you_ to write
> it because dpcm is totally and utterly unusable as it currently stands -
> as you can see from all the emails I've sent over the weekend.
I'm going to tell you to work with the framework rather than around it;
adding routes that link the CODEC and CPU together in parallel with the
links set up for the DAIs is not something that seems like it's going to
continue to work sensibly going forwards. If this were done at a
framework level that should be fine but having it as a special case in
some specific boards isn't good.
Since I don't have Kirkwood hardware or any particular use for it I've
no real intention of working on the hardware directly, sorry.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the linux-arm-kernel