[PATCH 1/2] pinctrl: imx: work around select input quirk

[Peter Chen]

On Mon, Aug 05, 2013 at 11:26:14AM +0800, Shawn Guo wrote:
> On Mon, Aug 05, 2013 at 09:14:50AM +0800, Peter Chen wrote:
> > On Sun, Aug 04, 2013 at 08:54:54PM +0800, Shawn Guo wrote:
> > > Yes, we changed the prefix to simplify the DTS files for imx6q and
> > > imx6dl.
> > > 
> > > > 
> > > > Besides, please add comments for u16 *input_reg at struct imx_pin_group.
> > > 
> > > I'm not fond of documenting a workaround for a random quirky select
> > > input as a feature all over the files where input_reg is documented.
> > > It should be good enough to have it well documented at where the quirk
> > > is handled.
> > 
> > If the user finds "odd value" at xxx-pinfunc.h, how he knows what
> > it stands for? At least, It should be documented where the user
> > can find its meaning.
> 
> We have it well documented in pinctrl-imx.c, function imx_pmx_enable()
> where the "odd value" is handled.
> 
> But I would try to look at the git log of xxx-pinfunc.h at the first
> place to see where and how the "odd value" comes.
> 

Yes, it is also OK.

-- 

Best Regards,
Peter Chen