[PATCH 1/2] pinctrl: imx: work around select input quirk

Peter Chen peter.chen at freescale.com
Sun Aug 4 21:14:50 EDT 2013


On Sun, Aug 04, 2013 at 08:54:54PM +0800, Shawn Guo wrote:
> Yes, we changed the prefix to simplify the DTS files for imx6q and
> imx6dl.
> 
> > 
> > Besides, please add comments for u16 *input_reg at struct imx_pin_group.
> 
> I'm not fond of documenting a workaround for a random quirky select
> input as a feature all over the files where input_reg is documented.
> It should be good enough to have it well documented at where the quirk
> is handled.

If the user finds "odd value" at xxx-pinfunc.h, how he knows what
it stands for? At least, It should be documented where the user
can find its meaning.

Best regards,
Peter




More information about the linux-arm-kernel mailing list