[PATCH] ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference

[Olof Johansson]

On Wed, Jul 10, 2013 at 10:03:17AM +0900, Simon Horman wrote:
> On Tue, Jul 09, 2013 at 05:09:52PM +0400, Sergei Shtylyov wrote:
> > Hello.
> > 
> > On 09-07-2013 17:03, Magnus Damm wrote:
> > 
> > >>>From: Magnus Damm <damm at opensource.se>
> > 
> > >>>Add support for the SMSC ethernet controller found
> > >>>on the KZM9D board to the KZM9D DT Reference code.
> > 
> > >>>Signed-off-by: Magnus Damm <damm at opensource.se>
> > >>>---
> > 
> > >>>   Built on top of renesas-next-20130704v2 and
> > >>>   [PATCH] ARM: shmobile: KZM9D DT reference implementation
> > 
> > >>>   arch/arm/boot/dts/emev2-kzm9d-reference.dts |   31
> > >>>+++++++++++++++++++++++++++
> > >>>   1 file changed, 31 insertions(+)
> > 
> > >>>--- 0002/arch/arm/boot/dts/emev2-kzm9d-reference.dts
> > >>>+++ work/arch/arm/boot/dts/emev2-kzm9d-reference.dts    2013-07-09
> > >>>13:06:47.000000000 +0900
> > >>>@@ -23,4 +23,35 @@
> > 
> > >>[...]
> > 
> > >>>+       lan9220 at 20000000 {
> > 
> > >>    Shouldn't all the Ethernet nodes be called "ethernet"?
> > 
> > >Good question. Grepping in arch/arm/boot/dts shows various ways to
> > >name the Ethernet nodes. Exactly what is correct or not I can't really
> > >say.
> > 
> >    See "Node Names" section of [1].
> > 
> > [1] http://www.devicetree.org/Device_Tree_Usage
> 
> I will queue up this patch for v3.12 in the dt branch and
> it should appear in renesas-next-20130710.
> 
> If there is a desire to consistently name nodes as "ethernet" for shmobile
> then I would appreciate a cleanup patches to fix all the relevant dts and
> dtsi files. One SoC or board per patch.

Yes, they should be named ethernet. Rename when you have a chance and/or are
touching the files for other nearby changes.

Also, the 9220 chips are usually located on a general-purpose external parallel
bus, but they're not modelled that way here. You might want to add proper
bindings for future devices on said busses (handling chipselects, etc, as
needed).


-Olof