[PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Aug 3 14:31:43 EDT 2013


On Fri, Aug 02, 2013 at 07:25:20PM +0300, Tero Kristo wrote:
> +
> +	if (cl)
> +		return cl;
> +
> +	/* If clock was not found, attempt to look-up from DT */
> +	node = of_find_node_by_name(NULL, con_id);

This is utterly broken if you're looking up purely by a connection ID.
Please, go back and read clk_get()'s documentation in linux/clk.h.
It's spelt out very plainly there.

NAK.



More information about the linux-arm-kernel mailing list