[PATCH v2] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

Felipe Balbi balbi at ti.com
Fri Aug 2 03:46:57 EDT 2013


Hi,

On Thu, Aug 01, 2013 at 07:07:50PM +0200, Boris BREZILLON wrote:
> @@ -1851,6 +1860,12 @@ fail3:
>  fail2:
>  	free_irq(udc->udp_irq, udc);
>  fail1:
> +	if (IS_ENABLED(CONFIG_COMMON_CLK) && !IS_ERR(udc->uclk))
> +		clk_put(udc->uclk);
> +	if (!IS_ERR(udc->fclk))
> +		clk_put(udc->fclk);
> +	if (!IS_ERR(udc->iclk))
> +		clk_put(udc->iclk);

adding missing clk_put() for iclk and fclk should be part of a separate
patch. Please split this part.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130802/e77b6f9e/attachment.sig>


More information about the linux-arm-kernel mailing list