[PATCH V2] ARM: allow DEBUG_UNCOMPRESS for Tegra

Alexandre Courbot gnurou at gmail.com
Fri Aug 2 03:21:57 EDT 2013


On Fri, Aug 2, 2013 at 10:59 AM, Alexandre Courbot <gnurou at gmail.com> wrote:
> On Fri, Aug 2, 2013 at 2:51 AM, Stephen Warren <swarren at wwwdotorg.org> wrote:
>> From: Stephen Warren <swarren at nvidia.com>
>>
>> DEBUG_UNCOMPRESS was previously disallowed for Tegra due to tegra.S's
>> use of global data that was not linked into the decompressor. Solve this
>> by declaring this symbol in tegra.S when it is being built into the
>> decompressor. For the kernel proper, leave the declaration in
>> mach-tegra/common.c as explained in the comment.
>
> Tested-by: Alexandre Courbot <acourbot at nvidia.com>
>
> Thanks, I had to workaround this when debugging a kernel uncompression
> issue, but have not yet found the time to craft a patch.

Also on a related note there is a compilation error on
arch/arm/boot/compressed/head.S if the DEBUG macro is defined (useful
to take advantage of puts and putc for early debugging) at least on
Tegra devices. The loadsp macro definition makes use of addruart,
which has been changed to take 3 arguments since about 2 years ago
(commit 639da5ee), but loadsp still uses the 2 arguments form. I'm not
sure how this should be fixed, either by adding another argument to
loadsp (which will turn out to be useless for most implementations) or
by using an arbitrary register in the definition that uses addruart
(probably dangerous).

Alex.



More information about the linux-arm-kernel mailing list