[PATCH v2 2/2] i2c: imx: Add Vybrid VF610 I2C controller support

Lu Jingchang-B35083 B35083 at freescale.com
Fri Aug 2 01:19:21 EDT 2013



> Using a struct type with a div and regval member would make the code
> surrounding this array more obviously correct. Would be nice to
> straighten this first before adding another array.
> 
> How about adding a regshift member instead? It seems shifting the vybrid
> registers by two bits is the imx registers.

 [Lu Jingchang-B35083] 
  Yes, using a struct for the i2c clock {div, regval} pairs would be more readable,
and the registers indeed have the same address offset.  I'll make some change and send
the v3 patch. Thanks!


Best Regards,
Jingchang




More information about the linux-arm-kernel mailing list