[V4 patch 02/15] ARM: ux500: cpuidle: replace for_each_online_cpu by for_each_possible_cpu

Chander Kashyap chander.kashyap at linaro.org
Tue Apr 30 05:16:55 EDT 2013


On 23 April 2013 14:24, Daniel Lezcano <daniel.lezcano at linaro.org> wrote:
> All the drivers are using, in their initialization function, the
> for_each_possible_cpu macro.
>
> Using for_each_online_cpu means the driver must handle the initialization
> of the cpuidle device when a cpu is up which is not the case here.
>
> Change the macro to for_each_possible_cpu as that fix the hotplug
> initialization and make the initialization routine consistent with the
> rest of the code in the different drivers.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano at linaro.org>
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
> ---
>  arch/arm/mach-ux500/cpuidle.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-ux500/cpuidle.c b/arch/arm/mach-ux500/cpuidle.c
> index c29c1bf..5657d4a 100644
> --- a/arch/arm/mach-ux500/cpuidle.c
> +++ b/arch/arm/mach-ux500/cpuidle.c
> @@ -125,7 +125,7 @@ int __init ux500_idle_init(void)
>                 return ret;
>         }
>
> -       for_each_online_cpu(cpu) {
> +       for_each_possible(cpu) {

for_each_possible(cpu) or for_each_possible_cpu(cpu) ?
>                 device = &per_cpu(ux500_cpuidle_device, cpu);
>                 device->cpu = cpu;
>                 ret = cpuidle_register_device(device);
> @@ -139,7 +139,7 @@ out:
>         return ret;
>
>  out_unregister:
> -       for_each_online_cpu(cpu) {
> +       for_each_possible_cpu(cpu) {
>                 device = &per_cpu(ux500_cpuidle_device, cpu);
>                 cpuidle_unregister_device(device);
>         }
> --
> 1.7.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



--
with warm regards,
Chander Kashyap



More information about the linux-arm-kernel mailing list