[V9 PATCH 01/12] usb: phy: protect phy init and shutdown for mutiple deivces

[Felipe Balbi]

On Wed, Apr 24, 2013 at 02:23:15AM -0400, Chao Xie wrote:
> diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h
> index 6b5978f..98d7e60 100644
> --- a/include/linux/usb/phy.h
> +++ b/include/linux/usb/phy.h
> @@ -87,6 +87,14 @@ struct usb_phy {
>  	/* to support controllers that have multiple transceivers */
>  	struct list_head	head;
>  
> +	/*
> +	 * PHY may be shared by multiple devices.
> +	 * mutex and refcount are used to make sure PHY only initialize or
> +	 * shutdown once.

bad grammar in this sentence.

> +	 */
> +	struct mutex		phy_mutex;
> +	unsigned int		refcount;

why don't you use an atomic_t ?

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130429/810dec42/attachment.sig>