[PATCH 17/32] dmaengine: ste_dma40: Remove redundant argument from d40_phy_cfg()

Linus Walleij linus.walleij at linaro.org
Thu Apr 25 07:14:18 EDT 2013


On Mon, Apr 22, 2013 at 12:18 PM, Lee Jones <lee.jones at linaro.org> wrote:

>> > +   if ((cfg->dir ==  STEDMA40_PERIPH_TO_MEM) ||
>> > +       (cfg->dir == STEDMA40_PERIPH_TO_PERIPH)) {
>>
>> Why would you need your own direction defines, I see that there is not much
>> diff between these and what dmaengine defines, so perhpas you could use
>> those?
>
> I agree. I'll speak to the STE folk.

This is because the driver was written before the dmaengine had
the enum dma_transfer_direction.

A simple search-and-replace patch would do the trick...

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list