[PATCH 2/2] dma: imx-sdma: move to generic device tree bindings

Arnd Bergmann arnd at arndb.de
Wed Apr 24 10:52:48 EDT 2013


On Wednesday 24 April 2013, Shawn Guo wrote:
> Using macros will help us to:
> 
> 1) Improve the readability of "dmas" property in dts
> 2) Keep the values stay in sync between kernel and DT
> 

I can understand the second part, but I strongly disagree on the first one.
Using symbolic constants in the DT will make it harder to understand because
you now have to look in multiple places to see what you actually put in there.

It makes some sense for the priorities, since they get reused for each
dma specifier.

	Arnd



More information about the linux-arm-kernel mailing list