[PATCH 2/2] dma: imx-sdma: move to generic device tree bindings
Arnd Bergmann
arnd at arndb.de
Wed Apr 24 10:26:22 EDT 2013
On Wednesday 24 April 2013, Shawn Guo wrote:
> +/*
> + * This enumerates peripheral types. Used for SDMA.
> + */
> +#define IMX_DMATYPE_SSI 0 /* MCU domain SSI */
> +#define IMX_DMATYPE_SSI_SP 1 /* Shared SSI */
> +#define IMX_DMATYPE_MMC 2 /* MMC */
> +#define IMX_DMATYPE_SDHC 3 /* SDHC */
> +#define IMX_DMATYPE_UART 4 /* MCU domain UART */
> +#define IMX_DMATYPE_UART_SP 5 /* Shared UART */
> +#define IMX_DMATYPE_FIRI 6 /* FIRI */
> +#define IMX_DMATYPE_CSPI 7 /* MCU domain CSPI */
> +#define IMX_DMATYPE_CSPI_SP 8 /* Shared CSPI */
> +#define IMX_DMATYPE_SIM 9 /* SIM */
> +#define IMX_DMATYPE_ATA 10 /* ATA */
> +#define IMX_DMATYPE_CCM 11 /* CCM */
> +#define IMX_DMATYPE_EXT 12 /* External peripheral */
> +#define IMX_DMATYPE_MSHC 13 /* Memory Stick Host Controller */
> +#define IMX_DMATYPE_MSHC_SP 14 /* Shared Memory Stick Host Controller */
> +#define IMX_DMATYPE_DSP 15 /* DSP */
> +#define IMX_DMATYPE_MEMORY 16 /* Memory */
> +#define IMX_DMATYPE_FIFO_MEMORY 17 /* FIFO type Memory */
> +#define IMX_DMATYPE_SPDIF 18 /* SPDIF */
> +#define IMX_DMATYPE_IPU_MEMORY 19 /* IPU Memory */
> +#define IMX_DMATYPE_ASRC 20 /* ASRC */
> +#define IMX_DMATYPE_ESAI 21 /* ESAI */
These macros don't seem helpful to me, since they are used in only one
place each. Why not put the literal numbers into the dts file directly?
Arnd
More information about the linux-arm-kernel
mailing list