[PATCH] ARM: pci: pass a parent to pci_common_init()

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Apr 19 09:19:17 EDT 2013


On Fri, Apr 12, 2013 at 02:48:11PM +0100, Andrew Murray wrote:
> Yes, though the new PCIe host/bridge drivers with DT support all seem to call
> pci_common_init at probe with a non-statically defined hw_pci with the
> nr_controllers always set to 1 (meaning that pci_common_init can be called
> multiple times). Also hw_pci now has a field for private_data anyway which
> breaks this assumption...
> 
> Is there an argument for removing hw_pci or at least .nr_controllers and call
> pci_common_init multiple times (as is potential current use case for DT PCI
> drivers)?

Well, I notice that there's bunches of code which have been introduced
post my cleanup of the PCI stuff which insist on doing their stuff using
the pre-cleanup ways...  I guess I need to go through and fix peoples
stuff up again in this area when I finish reading the mail backlog...

The idea behind bios32.c is that all buses get scanned and _then_ setup,
rather than each get scanned and setup in sequence.  This allows for
a variety of setups where the buses may share a space - it allows the
scan to be done, then the postinit hook to be called which can then do
any post-processing prior to resources being setup.



More information about the linux-arm-kernel mailing list