[PATCH v2 1/2] ARM: shmobile: R8A7779: add Ether support
Sergei Shtylyov
sergei.shtylyov at cogentembedded.com
Thu Apr 18 13:38:54 EDT 2013
Hello.
On 18-04-2013 19:36, Russell King - ARM Linux wrote:
>> +/* Ether */
>> +static struct resource ether_resources[] = {
>> + {
>> + .start = 0xfde00000,
>> + .end = 0xfde003ff,
>> + .flags = IORESOURCE_MEM,
>> + }, {
>> + .start = gic_iid(0xb4),
>> + .flags = IORESOURCE_IRQ,
>> + },
> There are macros for initializing these which have been around for a
> few years now.
I know, I know, just didn't know they're that old.
> Please consider using them in future.
This file uses the old style resource intializers generally, it just needs
wholesale conversion.
WBR, Sergei
More information about the linux-arm-kernel
mailing list