[PATCH 1/3] ARM: tegra: pcie: Add tegra3 support
Jay Agarwal
jagarwal at nvidia.com
Fri Apr 12 10:58:30 EDT 2013
> > err = regulator_disable(pcie->pex_clk_supply);
> > if (err < 0)
> > - dev_err(pcie->dev, "failed to disable pex-clk regulator:
> %d\n",
> > + dev_warn(pcie->dev, "failed to disable pex-clk regulator:
> %d\n",
> > err);
> >
> > err = regulator_disable(pcie->vdd_supply);
> > if (err < 0)
> > - dev_err(pcie->dev, "failed to disable VDD regulator: %d\n",
> > + dev_warn(pcie->dev, "failed to disable VDD regulator:
> %d\n",
> > err);
>
> Please explain why that change is correct. If the regulators only exist on
> Tegra20, please represent that fact in the SoC data. Regulators must always
> exist, so enable/disable should never fail due to missing regulators. Actual
> run-time failures seem like something that really is an error.
>
[>] These regulators are needed for both tegra20 & tegra30. Since we are not returning error here, so changed to dev_warn.
More information about the linux-arm-kernel
mailing list