[V2 patch 01/19] ARM: shmobile: cpuidle: remove shmobile_enter_wfi function

Simon Horman horms at verge.net.au
Fri Apr 12 03:06:21 EDT 2013


On 金,  4月 12, 2013 at 08:47:13午前 +0200, Daniel Lezcano wrote:
> On 04/12/2013 02:44 AM, Simon Horman wrote:
> > On Thu, Apr 11, 2013 at 10:42:31PM +0200, Daniel Lezcano wrote:
> >> Remove the shmobile_enter_wfi function which is the same as the
> >> common WFI enter function from the arm cpuidle driver defined
> >> with the ARM_CPUIDLE_WFI_STATE macro.
> > Should this patch also make shmobile_enter_wfi static in
> > arch/arm/mach-shmobile/cpuidle.c ?
> 
> Hum, no :)

Ok, that was my other idea :^)

> Actually, the function was removed because it was expected to be not
> longer used. I missed the cpuidle driver in the pm-sh7372.c file and the
> function declaration in the header file.
> > Also, I have a slight preference for the patch to be split into two.
> > 1. A patch to remove usage of shmobile_enter_wfi from the sh7372 SoC.
> > 2. A patch to remove shmobile_enter_wfi. from common.h
> >    (and make it static?).
> 
> Ok, regarding my answer above, do you still want two patches for this ?

Yes please.



More information about the linux-arm-kernel mailing list