[v2, 04/14] thermal: mvebu: Remove unneeded variable initialization
Eduardo Valentin
eduardo.valentin at ti.com
Thu Apr 11 14:54:17 EDT 2013
Ezequiel,
On 11-04-2013 12:29, Eduardo Valentin wrote:
> Rui, Ezequiel,
>
> On 22-03-2013 18:25, Ezequiel Garcia wrote:
>> This variable is used only after it's properly initialized,
>> so there's no need to set it to NULL in its declaration.
>>
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
>>
>
> I am fine with this patch. Though it doesn t hurt to have this
> initialization, the code looks cleaner though.
>
> Acked-by: Eduardo Valentin <eduardo.valentin at ti.com>
I know you have discarded the idea of merging the driver into a single
driver, but can you please resend this patch on top of
drivers/thermal/kirkwood_thermal.c file. This change still applies.
>
>
>> ---
>> drivers/thermal/mvebu_thermal.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/thermal/mvebu_thermal.c
>> b/drivers/thermal/mvebu_thermal.c
>> index 031f94d..1f502ed 100644
>> --- a/drivers/thermal/mvebu_thermal.c
>> +++ b/drivers/thermal/mvebu_thermal.c
>> @@ -72,7 +72,7 @@ MODULE_DEVICE_TABLE(of, mvebu_thermal_id_table);
>>
>> static int mvebu_thermal_probe(struct platform_device *pdev)
>> {
>> - struct thermal_zone_device *thermal = NULL;
>> + struct thermal_zone_device *thermal;
>> struct mvebu_thermal_priv *priv;
>> struct resource *res;
>>
>>
>
>
>
More information about the linux-arm-kernel
mailing list