[PATCH v4] mmc: dw_mmc: let device core setup the default pin configuration

Doug Anderson dianders at chromium.org
Wed Apr 10 10:55:25 EDT 2013


Thomas,

On Wed, Apr 10, 2013 at 6:56 AM, Doug Anderson <dianders at chromium.org> wrote:
> On Wed, Apr 10, 2013 at 5:48 AM, Thomas Abraham
> <thomas.abraham at linaro.org> wrote:
>> The call to regulator_enable() is prior to the call to mmc_add_host().
>> Hence, call to mmc_fre_host is not required in this case. So the above
>> change should be right.
>
> Are you sure that mmc_free_host() is the opposite of mmc_add_host()
> and not mmc_alloc_host()?
>
> I'll double-check myself in a few hours when I'm in front of a computer.

OK, I double checked and I'm still convinced that the free is needed
because we've already called mmc_alloc_host().  Current code always
makes sure to free when it returns an error and that seems right to
me.

-Doug



More information about the linux-arm-kernel mailing list