[PATCH 4/5] dmaengine: ste_dma40: Only configure a channel during a configure request
Lee Jones
lee.jones at linaro.org
Mon Apr 8 11:23:10 EDT 2013
According to the DMA documentation allocating a channel and configuring
it are two separate actions. By moving the configuration code into the
correct code path we lighten the burden on the information required to
successfully allocate a channel.
Cc: Vinod Koul <vinod.koul at intel.com>
Cc: Dan Williams <djbw at fb.com>
Cc: Per Forlin <per.forlin at stericsson.com>
Signed-off-by: Lee Jones <lee.jones at linaro.org>
---
drivers/dma/ste_dma40.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index ecca492..3543ea4 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -2471,16 +2471,10 @@ static int d40_alloc_chan_resources(struct dma_chan *chan)
}
pm_runtime_get_sync(d40c->base->dev);
- /* Fill in basic CFG register values */
- d40_phy_cfg(&d40c->dma_cfg, &d40c->src_def_cfg,
- &d40c->dst_def_cfg, chan_is_logical(d40c));
d40_set_prio_realtime(d40c);
if (chan_is_logical(d40c)) {
- d40_log_cfg(&d40c->dma_cfg,
- &d40c->log_def.lcsp1, &d40c->log_def.lcsp3);
-
if (d40c->dma_cfg.dir == STEDMA40_PERIPH_TO_MEM)
d40c->lcpa = d40c->base->lcpa_base +
d40c->dma_cfg.src_dev_type * D40_LCPA_CHAN_SIZE;
--
1.7.10.4
More information about the linux-arm-kernel
mailing list