[PATCH] arm: mvebu: Fix the irq map function in SMP mode

[Ryan Press]

On Fri, Apr 5, 2013 at 5:32 AM, Gregory CLEMENT
<gregory.clement at free-electrons.com> wrote:
> This patch fix the regression introduced by the commit 3202bf0157ccb
> "arm: mvebu: Improve the SMP support of the interrupt controller":
> GPIO IRQ were no longer delivered to the CPUs.
>
> To be delivered to a CPU an interrupt must be enabled at CPU level and
> at interrupt source level. Before the offending patch, all the
> interrupts were enabled at source level during map() function. Mask()
> and unmask() was done by handling the per-CPU part. It was fine when
> running in UP with only one CPU.
>
> The offending patch added support for SMP, in this case mask() and
> unmask() was done by handling the interrupt source level part. The
> per-CPU level part was handled by the affinity API to select the CPU
> which will receive the interrupt. (Due to some hardware limitation
> only one CPU at a time can received a given interrupt).
>
> For "normal" interrupt __setup_irq() was called when an irq was
> registered. irq_set_affinity() is called from this function, which
> enabled the interrupt on one of the CPUs. Whereas for GPIO IRQ which
> were chained interrupts, the irq_set_affinity() was never called and
> none of the CPUs was selected to receive the interrupt.
>
> With this patch all the interrupt are enable on the current CPU during
> map() function. Enabling the interrupts on a CPU doesn't depend
> anymore on irq_set_affinity() and then the chained irq are not anymore
> a special case. However the CPU which will receive the irq can still
> be modify later using irq_set_affinity().
>
> Signed-off-by: Gregory CLEMENT <gregory.clement at free-electrons.com>
> Reported-by: Ryan Press <ryan at presslab.us>
> Investigated-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
> Tested-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
>
> Tested with Mirabox (A370) and Openblocks AX3 (AXP), rootfs mounted
> over NFS, compiled with CONFIG_SMP=y/N.


Thanks guys, I turned CONFIG_SMP back on and the gpio-keys button now
works great!

Tested-by: Ryan Press <ryan at presslab.us>


Ryan