[PATCH] Revert "OMAP/serial: Fix incorrect Rx FIFO threshold setting, LSR validation on Tx, and Tx FIFO IRQ generation"

[Grazvydas Ignotas]

On Thu, Apr 4, 2013 at 12:06 AM, Alexey Pelykh <alexey.pelykh at gmail.com> wrote:
>
> Is it possible to check behavior on 3.0-3.2 kernels?

We use 3.2 on pandora as production kernel and it doesn't have this
issue that 3.9 had. 3.2 serial PM code is vastly different from what's
in later ones though.

>
> On Wed, Apr 3, 2013 at 11:57 PM, Paul Walmsley <paul at pwsan.com> wrote:
>> Hi Alexey,
>>
>> On Wed, 3 Apr 2013, Alexey Pelykh wrote:
>>
>>> But, since we've found the issue, I suggest that we should look at it
>>> closer, especially since at this moment only you can reproduce it.
>>
>> Well probably no one else is testing it :-)
>>
>>> As far as I understand, but I may be wrong, this comment is wrong, since
>>> if to specify OMAP_UART_SCR_RX_TRIG_GRANU1_MASK, it effectively sets Rx
>>> threshold to 1 character, instead of 16. /* Set receive FIFO threshold
>>> to 16 characters and
>>>  * transmit FIFO threshold to 16 spaces
>>>  */
>>
>> Again it certainly would not surprise me... that UART IP block seems to be
>> poorly understood :-(  Bizarre, I know.
>>
>> - Paul

--
Gražvydas