[PATCH] Revert "OMAP/serial: Fix incorrect Rx FIFO threshold setting, LSR validation on Tx, and Tx FIFO IRQ generation"

Paul Walmsley paul at pwsan.com
Wed Apr 3 16:57:28 EDT 2013


Hi Alexey,

On Wed, 3 Apr 2013, Alexey Pelykh wrote:

> But, since we've found the issue, I suggest that we should look at it
> closer, especially since at this moment only you can reproduce it.

Well probably no one else is testing it :-)

> As far as I understand, but I may be wrong, this comment is wrong, since 
> if to specify OMAP_UART_SCR_RX_TRIG_GRANU1_MASK, it effectively sets Rx 
> threshold to 1 character, instead of 16. /* Set receive FIFO threshold 
> to 16 characters and
>  * transmit FIFO threshold to 16 spaces
>  */

Again it certainly would not surprise me... that UART IP block seems to be 
poorly understood :-(  Bizarre, I know.

- Paul



More information about the linux-arm-kernel mailing list