On Wed, Apr 03, 2013 at 11:46:52AM +0200, Ulf Hansson wrote: > + clk_reg = devm_clk_register(clk->dev, &clk->hw); > + if (IS_ERR_OR_NULL(clk_reg)) { Please go and read the devm_clk_register() code and work out whether your check above is appropriate. Thanks.