[PATCH 1/2] ARM: shmobile: R8A7779: add Ether support

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Tue Apr 2 20:08:55 EDT 2013


Hi Sergei

> > Then, this (void *pdata) should be
> > (struct sh_eth_plat_data *pdata) IMO
> 
>     ether_device.dev.platform_data is 'void *'. I didn't want to bring in 
> extra header for the little use.

Not enough reason for me.

"void *" means there is no pointer check,
and extra header is just 1 line. No ?

If you want to use this style,
then, additional extra header is fate, IMO

Best regards
---
Kuninori Morimoto



More information about the linux-arm-kernel mailing list