[PATCH] ARM: kirkwood: DT board setup for CloudBox

Jason Cooper jason at lakedaemon.net
Tue Apr 2 07:45:35 EDT 2013


On Tue, Apr 02, 2013 at 06:17:10AM +0200, Chris Moore wrote:
> Le 01/04/2013 18:33, Simon Guinot a écrit :
...
> >The new CloudBox is a very different product which has been first named
> >FamilyBox and then released under the CloudBox name.

The question really comes down to, are there *any* differences on the
_board_?

If there are hardware differences, we need two dts files and two
compatibility strings.  Preferably appending the baseline model number
to each.  If they unwisely chose the same model number, we should append
'-db' or '-dev-board' to the compatibility string of the first board.

Although, in this case, there is a netspace_mini_v2 already in the
kernel (kirkwood-ns2mini.dts).  Is this the development version you were
speaking of?

> Are all the new ones white and all the old ones black?
> If so, can't we add white to the name or at least specify in Kconfig
> that it is the white version with a 3.5" disk?

No.  Colors don't tell us squat about the hardware differences.  Colors
change at the whim of marketing/management/region/time-of-year.  Model
numbers also aren't perfect, but they're much more reliable for
determining which board you have.

Also, the individual Kconfig board entries are going away.  So I
wouldn't encode anything in there you want kept around for the life of
the board.  A comment in the dts file would be better.

thx,

Jason.



More information about the linux-arm-kernel mailing list