[PATCH 1/2] ARM: shmobile: R8A7779: add Ether support

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Mon Apr 1 20:27:13 EDT 2013


Hi Sergei again

> +void __init r8a7779_add_ether_device(void *pdata)
> +{
> +	ether_device.dev.platform_data = pdata;
> +
> +	platform_device_register(&ether_device);
> +}

We didn't use this style of registration before,
but, it is OK.
Then, this (void *pdata) should be
(struct sh_eth_plat_data *pdata) IMO

Best regards
---
Kuninori Morimoto



More information about the linux-arm-kernel mailing list