[PATCH 3/3 v2] ARM: shmobile: bockw: add SMSC ethernet support
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Mon Apr 1 20:13:10 EDT 2013
Hi Sergei, Simon
> > chosen {
> > - bootargs = "console=ttySC0,115200 ignore_loglevel";
> > + bootargs = "console=ttySC0,115200 ignore_loglevel ip=dhcp root=/dev/nfs";
> > };
> >
> > memory {
>
> In my opinion, modifying .dts file should be done in a separate patch.
(snip)
> > # CONFIG_SCHED_DEBUG is not set
> > # CONFIG_DEBUG_BUGVERBOSE is not set
> > # CONFIG_FTRACE is not set
> > # CONFIG_ARM_UNWIND is not set
> > -CONFIG_KEYS=y
> > -CONFIG_CRYPTO=y
> > CONFIG_AVERAGE=y
>
> In my opinion, modifying bockw_defconfig should be done in a separate
> patch. Mixing everything up in a signle patch is a bad practice.
It depends on LTSI backport / upstreaming I believe.
I need Simon's opinion
Best regards
---
Kuninori Morimoto
More information about the linux-arm-kernel
mailing list