[PATCH 2/5] spi/mxs: Fix chip select control bits in DMA mode

Trent Piepho tpiepho at gmail.com
Mon Apr 1 19:40:37 EDT 2013


On Mon, Apr 1, 2013 at 4:30 PM, Marek Vasut <marex at denx.de> wrote:

>> >> -static uint32_t mxs_spi_cs_to_reg(unsigned cs)
>> >> +static u32 mxs_spi_cs_to_reg(unsigned cs)
>> >>
>> >>  {
>> >>
>> >> -     uint32_t select = 0;
>> >> +     u32 select = 0;
>>
>> I'll make it a separate patch.
>
> This is completely irrelevant change, please just submit the relevant patches.

Kernel code should use u16, u32, etc. instead of the uint16_t,
uint32_t types.  The rest of the driver uses them.  Why should this
one function use a different type than the rest?  It's ugly and
inconsistent.

And really, it's just as relevant as insisting that multiline patches
use some exact format, which checkpatch.pl doesn't complain about.



More information about the linux-arm-kernel mailing list