[PATCH] ARM: davinci: use is IS_ENABLED macro

Sekhar Nori nsekhar at ti.com
Mon Apr 1 02:12:17 EDT 2013


On 3/28/2013 10:07 AM, Prabhakar Lad wrote:
> Hi Sekhar,
> 
> On Wed, Mar 27, 2013 at 4:13 PM, Stephen Rothwell <sfr at canb.auug.org.au> wrote:
>> Hi,
>>
>> On Mon, 25 Mar 2013 16:51:35 +0530 Prabhakar lad <prabhakar.csengg at gmail.com> wrote:
>>>
>>> --- a/arch/arm/mach-davinci/board-da830-evm.c
>>> +++ b/arch/arm/mach-davinci/board-da830-evm.c
>>> @@ -298,7 +298,7 @@ static const short da830_evm_emif25_pins[] = {
>>>       -1
>>>  };
>>>
>>> -#if defined(CONFIG_MMC_DAVINCI) || defined(CONFIG_MMC_DAVINCI_MODULE)
>>> +#if IS_ENABLED(CONFIG_MMC_DAVINCI)
>>>  #define HAS_MMC      1
>>>  #else
>>>  #define HAS_MMC      0
>>
>> Why not
>>
>> #define HAS_MMC         IS_ENABLED(CONFIG_MMC_DAVINCI)
>>
>> and similarly in the rest?
>>
> Stephen's suggestion looks good to me, if you haven’t queued it i'll post a v2,
> or if you have already queued it I'll create a patch on top of the
> same patch fixing it.
> lemme know how would you want it.

Please post a v2. I will take that instead.

Thanks,
Sekhar



More information about the linux-arm-kernel mailing list