[PATCH 15/16] ARM: Kirkwood: Describe iConnect LEDs in DT.

Arnaud Patard (Rtp) arnaud.patard at rtp-net.org
Tue Jul 31 04:59:14 EDT 2012


Andrew Lunn <andrew at lunn.ch> writes:

> On Tue, Jul 31, 2012 at 09:08:53AM +0200, Arnaud Patard wrote:
>> Andrew Lunn <andrew at lunn.ch> writes:
>> 
>> > On Mon, Jul 30, 2012 at 10:35:34PM +0100, Adam Baker wrote:
>> >> On 20/07/12 18:35, Andrew Lunn wrote:
>> >> 
>> >> Sorry it's taken a while to spot this but I've got one comment below
>> >> 
>> >> >Signed-off-by: Andrew Lunn <andrew at lunn.ch>
>> >> >---
>> >> >  arch/arm/boot/dts/kirkwood-iconnect.dts |   34 +++++++++++++++++++++++
>> >> >  arch/arm/mach-kirkwood/board-iconnect.c |   46 -------------------------------
>> >> >  2 files changed, 34 insertions(+), 46 deletions(-)
>> >> >
>> >> >diff --git a/arch/arm/boot/dts/kirkwood-iconnect.dts b/arch/arm/boot/dts/kirkwood-iconnect.dts
>> >> >index a7dd07b..b77b38f 100644
>> >> >--- a/arch/arm/boot/dts/kirkwood-iconnect.dts
>> >> >+++ b/arch/arm/boot/dts/kirkwood-iconnect.dts
>> >> >@@ -31,4 +31,38 @@
>> >> >  			status = "ok";
>> >> >  		};
>> >> >  	};
>> >> >+	gpio-leds {
>> >> >+		compatible = "gpio-leds";
>> >> >+
>> >> >+		led-level {
>> >> >+			label = "led_level";
>> >> >+			gpios = <&gpio1 9 0>;
>> >> >+			linux,default-trigger = "default-on";
>> >> >+		};
>> >> >+		power-blue {
>> >> >+			label = "power:blue";
>> >> >+			gpios = <&gpio1 11 0>;
>> >> >+			linux,default-trigger = "timer";
>> >> >+		};
>> >> 
>> >> Is there any reason that power:red is missing here?
>> >
>> > The monkey driving the keyboard is not reliable at monkey work...
>> >
>> > Please create a patch and i will try to get it into rc1.
>> 
>> There's already a patch for that in your mailbox ("ARM: Kirkwood: Fix
>> iconnect leds"). I guess you're not yet fully awake :)
>
> Hi Arnaud
>
> Still need my second coffee of the day.
>
> Those patches never went to the list, as far as i remember. Please can
> you post the two fixes and the two development patches, as seperate
> patchsets.

Will do.

Thanks,
Arnaud



More information about the linux-arm-kernel mailing list