[PATCH v2 4/7] ARM: pxa: add devicetree code for irq handling

Arnd Bergmann arnd at arndb.de
Mon Jul 30 04:31:32 EDT 2012


On Sunday 29 July 2012, Daniel Mack wrote:
> Hmm, PXA25x (which does not feature IRQ priorities) shares a fair amount
> of peripherals with other PXA series (which do have support for that). I
> would much like to reflect that fact by inherhiting device nodes from
> one dtsi to the other. Hence, if at all, we would need to have two cells
> always, and just ignore the second argument on PXA25x.

But that can only work if the interrupt numbers are identical between PXA25x
and the other SoCs. Are they?

> And I also wonder whether using the second spec value for a priority
> wouldn't be somehow abusive? Isn't that considered to denote the trigger
> flags in contexts of interrupt controllers? At least, that is what
> irq_domain_xlate_twocell() assumes.

You would not use irq_domain_xlate_twocell in that scenario but provide your
own, which is ok. Interpreting the second cell as the trigger flags is just
a convenient default because it's the most common use for that.

	Arnd



More information about the linux-arm-kernel mailing list