[PATCH v5 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration

Mohammed, Afzal afzal at ti.com
Mon Jul 30 03:36:39 EDT 2012


Hi Tony,

On Thu, Jun 28, 2012 at 18:14:30, Mohammed, Afzal wrote:
> On Thu, Jun 28, 2012 at 18:02:07, Tony Lindgren wrote:
> > * Mohammed, Afzal <afzal at ti.com> [120628 02:36]:

> > > diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c
> > > index c8a9487..bbae674 100644
> > > --- a/arch/arm/mach-omap2/gpmc-onenand.c
> > > +++ b/arch/arm/mach-omap2/gpmc-onenand.c
> > > @@ -364,6 +364,8 @@ static int omap2_onenand_setup_async(void __iomem *onenand_base)
> > >         struct gpmc_timings t;
> > >         int ret;
> > > 
> > > +       omap2_onenand_set_async_mode(onenand_base);
> > > +
> > >         t = omap2_onenand_calc_async_timings();
> > > 
> > >         ret = gpmc_set_async_mode(gpmc_onenand_data->cs, &t);
> > 
> > Yes that seems to do the trick, thanks! I can fold that into the
> > breaking patch when applying.
> 
> 
> Also following needs to be removed from commit message,
> 
> "Ensuring sync read/write are disabled in onenand cannot
> be expected to work properly unless GPMC is setup, this
> has been removed."
> 
> With the above diff we are in effect disabling sync mode in
> onenand before GPMC has been setup in the Kernel
> 
> If you want, I can sent a new series too.

Can you please take this series along with the above changes
folded in $subject patch. I & Jon concurred on this as a
solution in this same thread (along with preventing
hwmod reset, which is taken care in hwmod patch).

Please let me know whether you prefer to have a separate series
posted inclusive of the above changes.

Regards
Afzal



More information about the linux-arm-kernel mailing list